fix: ordering keys publishing of last batch#9
Merged
kamalaboulhosn merged 3 commits intogoogleapis:masterfrom Nov 26, 2019
kamalaboulhosn:master
Merged
fix: ordering keys publishing of last batch#9kamalaboulhosn merged 3 commits intogoogleapis:masterfrom kamalaboulhosn:master
kamalaboulhosn merged 3 commits intogoogleapis:masterfrom
kamalaboulhosn:master
Conversation
…isherServiceImpl.java
…e currently outstanding message has finished publishing with an ordering key that the last batch does in fact get published.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
===========================================
+ Coverage 78.76% 78.8% +0.04%
- Complexity 285 288 +3
===========================================
Files 21 21
Lines 2566 2576 +10
Branches 125 128 +3
===========================================
+ Hits 2021 2030 +9
Misses 490 490
- Partials 55 56 +1
Continue to review full report at Codecov.
|
hannahrogers-google
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the last batch for an ordering key gets published.