Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry streaming subscriber connections on unknown #92

Merged

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Feb 20, 2020

When a streaming subscriber connection is terminated due to an UNKNOWN error, we will now try re-establishing that connection.

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label Feb 20, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #92 into master will increase coverage by 0.93%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     78.94%   79.88%   +0.93%     
- Complexity      293      305      +12     
============================================
  Files            21       21              
  Lines          2598     2600       +2     
  Branches        129      129              
============================================
+ Hits           2051     2077      +26     
+ Misses          492      467      -25     
- Partials         55       56       +1
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java 83.8% <ø> (ø) 19 <0> (ø) ⬇️
...com/google/cloud/pubsub/v1/TopicAdminSettings.java 21.27% <ø> (ø) 5 <0> (ø) ⬇️
...in/java/com/google/cloud/pubsub/v1/StatusUtil.java 71.42% <ø> (ø) 4 <0> (ø) ⬇️
...e/cloud/pubsub/v1/stub/SubscriberStubSettings.java 85.05% <ø> (ø) 27 <0> (ø) ⬇️
...gle/cloud/pubsub/v1/SubscriptionAdminSettings.java 14.28% <ø> (ø) 4 <0> (ø) ⬇️
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.39% <100%> (+0.54%) 9 <0> (ø) ⬇️
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.14% <0%> (-0.5%) 25% <0%> (ø)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 65.18% <0%> (+1.48%) 32% <0%> (+2%) ⬆️
...google/cloud/pubsub/v1/stub/GrpcPublisherStub.java 95.75% <0%> (+1.88%) 17% <0%> (+1%) ⬆️
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 69.08% <0%> (+2.89%) 52% <0%> (+6%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548b7a7...6e46ec2. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit d702a5c into googleapis:master Feb 20, 2020
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants