Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a default value for max outstanding request bytes flow control setting #96

Merged
merged 22 commits into from Feb 24, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Feb 24, 2020

Fixes #95

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@googlebot googlebot added the cla: yes label Feb 24, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 24, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
+ Coverage     79.88%   79.94%   +0.06%     
  Complexity      305      305              
============================================
  Files            21       21              
  Lines          2600     2603       +3     
  Branches        129      129              
============================================
+ Hits           2077     2081       +4     
  Misses          467      467              
+ Partials         56       55       -1     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.64% <0.00%> (+0.49%) 25.00% <0.00%> (ø%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fde3a...b4439fd. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit 4a6046c into googleapis:master Feb 24, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants