Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated tag that was added prematurely #97

Merged
merged 9 commits into from Feb 27, 2020
Merged

fix: remove deprecated tag that was added prematurely #97

merged 9 commits into from Feb 27, 2020

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Feb 26, 2020

Fixes #58

@googlebot googlebot added the cla: yes label Feb 26, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

Merging #97 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
- Coverage     79.94%   79.90%   -0.04%     
  Complexity      305      305              
============================================
  Files            21       21              
  Lines          2603     2603              
  Branches        129      129              
============================================
- Hits           2081     2080       -1     
  Misses          467      467              
- Partials         55       56       +1     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.14% <0.00%> (-0.50%) 25.00% <0.00%> (ø%)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.00% <0.00%> (ø) 22.00% <0.00%> (ø%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f803bee...b4a2989. Read the comment docs.

Copy link
Contributor

@hannahrogers-google hannahrogers-google left a comment

LGTM. Can you just run 'mvn clean verify' before submitting to correct the formatting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants