samples: exit early if no messages are returned #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: pubsub
anguillanneuf
changed the title
anguillanneuf
changed the title
anguillanneuf
changed the title
kurtisvg
suggested changes
Feb 3, 2022
| // Exit the program if the pull response is empty. | ||
| if (pullResponse.getReceivedMessagesList().isEmpty()) { | ||
| System.out.println("No message was pulled. Exiting."); | ||
| System.exit(0); |
There was a problem hiding this comment.
System.exit probably isn't what you want here (it may crash the tests) - don't you just want to return?
Contributor
Author
There was a problem hiding this comment.
You're right. Updated to return.
| // Exit the program if the pull response is empty. | ||
| if (pullResponse.getReceivedMessagesList().isEmpty()) { | ||
| System.out.println("No message was pulled. Exiting."); | ||
| System.exit(0); |
| // Use pullCallable().futureCall to asynchronously perform this operation. | ||
| PullResponse pullResponse = subscriber.pullCallable().call(pullRequest); | ||
|
|
||
| // Exit the program if the pull response is empty. |
There was a problem hiding this comment.
This comment tells me what you are doing (but so does the code). Can we update it to tell me why we are doing?
Contributor
Author
There was a problem hiding this comment.
That's a good point. Updated.
kurtisvg
approved these changes
Feb 3, 2022
rajanya-google
pushed a commit
to rajanya-google/java-pubsub
that referenced
this pull request
Feb 16, 2022
* samples: exit early if no messages are pulled * address kurtis's comments * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189
The current samples will fail with
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: You have not specified an ack ID in the requestif no messages are returned. Updating them to handle this case.This does not affect the existing tests for the samples.
I also noticed something that should not have been published with one of the samples in the first place - my project and topic ID. Apologies.