Skip to content

samples: exit early if no messages are returned #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2022
Merged

samples: exit early if no messages are returned #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebcae5d
samples: exit early if no messages are pulled
anguillanneuf Feb 3, 2022
f7cc282
address kurtis's comments
anguillanneuf Feb 3, 2022
3bcf888
update comment
anguillanneuf Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions samples/snippets/src/main/java/pubsub/SubscribeSyncExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,21 @@ public static void subscribeSyncExample(

// Use pullCallable().futureCall to asynchronously perform this operation.
PullResponse pullResponse = subscriber.pullCallable().call(pullRequest);

// Stop the program if the pull response is empty to avoid acknowledging
// an empty list of ack IDs.
if (pullResponse.getReceivedMessagesList().isEmpty()) {
System.out.println("No message was pulled. Exiting.");
return;
}

List<String> ackIds = new ArrayList<>();
for (ReceivedMessage message : pullResponse.getReceivedMessagesList()) {
// Handle received message
// ...
ackIds.add(message.getAckId());
}

// Acknowledge received messages.
AcknowledgeRequest acknowledgeRequest =
AcknowledgeRequest.newBuilder()
Expand Down
11 changes: 7 additions & 4 deletions samples/snippets/src/main/java/pubsub/SubscribeSyncWithLeaseExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ public static void main(String... args) throws Exception {
String subscriptionId = "your-subscription-id";
Integer numOfMessages = 10;

projectId = "tz-playground-bigdata";
subscriptionId = "uno";

subscribeSyncWithLeaseExample(projectId, subscriptionId, numOfMessages);
}

Expand Down Expand Up @@ -68,8 +65,14 @@ public static void subscribeSyncWithLeaseExample(
// Use pullCallable().futureCall to asynchronously perform this operation.
PullResponse pullResponse = subscriber.pullCallable().call(pullRequest);

List<String> ackIds = new ArrayList<>();
// Stop the program if the pull response is empty to avoid acknowledging
// an empty list of ack IDs.
if (pullResponse.getReceivedMessagesList().isEmpty()) {
System.out.println("No message was pulled. Exiting.");
return;
}

List<String> ackIds = new ArrayList<>();
for (ReceivedMessage message : pullResponse.getReceivedMessagesList()) {
ackIds.add(message.getAckId());

Expand Down