feat: PSL Connector Writer support#121
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 58.96% 59.52% +0.55%
- Complexity 92 129 +37
============================================
Files 18 24 +6
Lines 580 751 +171
Branches 24 31 +7
============================================
+ Hits 342 447 +105
- Misses 232 296 +64
- Partials 6 8 +2
Continue to review full report at Codecov.
|
jiangmichaellll
commented
Mar 30, 2021
dpcollins-google
suggested changes
Mar 30, 2021
dpcollins-google
left a comment
Contributor
There was a problem hiding this comment.
LGTM after remaining fixes, ping me after those are done.
Contributor
|
clirr is going to be mad about this PR, you'll need to add allowed exceptions for all the things you've moved to an internal file. Also, look at the clirr file for the main library and allow breaking changes in all internal directories. |
dpcollins-google
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.