deps: update to google-cloud-pubsublite to v0.15.0#192
Merged
Conversation
product-auto-label
Bot
added
the
api: pubsublite
google-cla
Bot
added
the
cla: yes
1 task
jiangmichaellll
approved these changes
Jun 10, 2021
jiangmichaellll
left a comment
jiangmichaellll
left a comment
Contributor
There was a problem hiding this comment.
LGTM, lambda sometimes cause issues b/c of serializable, but in this case PartitionSubscriberFactory is serializable and the integration test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual update to handle the interface change of
BlockingPullSubscriberImpl- theSubscriberBuildernow accepts an initial location when connecting a new Subscribe stream and an additional seek request is not necessary.An offset parameter was added to
PartitionSubscriberFactoryin order to pass the initiation offset through toSubscriberBuilder.