Skip to content

docs: Update readme about jar name.#73

Merged
anguillanneuf merged 2 commits into
masterfrom
jiangmichael-doc-update
Feb 11, 2021
Merged

docs: Update readme about jar name.#73
anguillanneuf merged 2 commits into
masterfrom
jiangmichael-doc-update

Conversation

@jiangmichaellll
Copy link
Copy Markdown
Contributor

No description provided.

@jiangmichaellll jiangmichaellll requested review from a team February 10, 2021 23:58
@google-cla google-cla Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 10, 2021
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 10, 2021
Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay we replace 0.1.0 with $VERSION and describe it as the "latest release version"?

This is so that we don't need to touch at least the samples README every time there's a version bump.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2021

Codecov Report

Merging #73 (1771253) into master (b0eb9e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #73   +/-   ##
=========================================
  Coverage     58.39%   58.39%           
  Complexity       81       81           
=========================================
  Files            17       17           
  Lines           524      524           
  Branches         18       18           
=========================================
  Hits            306      306           
  Misses          215      215           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eb9e0...d1cffa4. Read the comment docs.

@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking up this cool trick to get sample version.

@anguillanneuf anguillanneuf merged commit 7f24f1e into master Feb 11, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-doc-update branch February 11, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants