fix: Better error message when subscription path is invalid.#87
Merged
jiangmichaellll merged 2 commits intoFeb 22, 2021
Merged
Conversation
google-cla
Bot
added
the
api: pubsublite
product-auto-label
Bot
added
the
api: pubsublite
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
============================================
+ Coverage 58.31% 59.46% +1.15%
- Complexity 81 82 +1
============================================
Files 17 17
Lines 523 528 +5
Branches 17 18 +1
============================================
+ Hits 305 314 +9
+ Misses 215 210 -5
- Partials 3 4 +1
Continue to review full report at Codecov.
|
anguillanneuf
approved these changes
Feb 22, 2021
Contributor
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
Some lines are not covered by tests?
Contributor
Author
|
it's now all covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.