Skip to content

Commit

Permalink
fix: Make flogger a runtime dependency by default. (#265)
Browse files Browse the repository at this point in the history
Fixes #213
  • Loading branch information
dpcollins-google committed Sep 28, 2020
1 parent ce39696 commit 747bc66
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 31 deletions.
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ If you are using Maven, add this to your pom.xml file:
<artifactId>google-cloud-pubsub</artifactId>
<version>1.108.1</version>
</dependency>
<!-- A logging dependency used by the underlying library -->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>runtime</scope>
</dependency>

```

Expand Down
6 changes: 4 additions & 2 deletions google-cloud-pubsublite/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,15 @@
<artifactId>grpc-protobuf</artifactId>
</dependency>

<!--test dependencies-->
<!-- Add system backend as a default dependency. This can be excluded if a different backend is needed.-->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>test</scope>
<scope>runtime</scope>
</dependency>

<!--test dependencies-->
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
Expand Down
7 changes: 0 additions & 7 deletions pubsublite-beam-io/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@
</dependency>

<!--test dependencies-->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down Expand Up @@ -143,7 +137,6 @@
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>io.grpc:grpc-testing</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>com.google.flogger:flogger-system-backend</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>org.apache.beam:beam-runners-direct-java</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
Expand Down
8 changes: 0 additions & 8 deletions samples/snapshot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@
<version>1.108.1</version>
</dependency>

<!-- A logging dependency used by the underlying library -->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
7 changes: 0 additions & 7 deletions samples/snippets/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@
<artifactId>google-cloud-pubsub</artifactId>
<version>1.108.1</version>
</dependency>
<!-- A logging dependency used by the underlying library -->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>runtime</scope>
</dependency>
<!-- [END pubsublite_java_dependencies] -->
<!-- [END pubsublite_install_without_bom] -->

Expand Down

0 comments on commit 747bc66

Please sign in to comment.