Skip to content

Commit

Permalink
feat: Add SharedBehavior class which handles the PartitionsFor method…
Browse files Browse the repository at this point in the history
… on consumers and producers (#278)

* fix: Implement rethrowAsRuntime and clean up ExtractStatus

* feat: Implement interfaces and utilities needed for Pub/Sub Lite Kafka shim

* fix: Formatting changes

* deps: Fix dependencies

* feat: Add SharedBehavior class which handles the PartitionsFor method on consumers and producers.

* chore: Run linter
  • Loading branch information
dpcollins-google committed Oct 5, 2020
1 parent 3c43ef3 commit b42da5f
Show file tree
Hide file tree
Showing 3 changed files with 122 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pubsublite-kafka-shim/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@
<artifactId>truth-java8-extension</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud.pubsublite.kafka;

import static com.google.cloud.pubsublite.kafka.KafkaExceptionUtils.toKafka;

import com.google.cloud.pubsublite.AdminClient;
import com.google.cloud.pubsublite.Partition;
import com.google.cloud.pubsublite.TopicPath;
import com.google.common.collect.ImmutableList;
import java.time.Duration;
import java.util.List;
import java.util.concurrent.TimeUnit;
import org.apache.kafka.common.PartitionInfo;

/** Shared behavior for producer and consumer. */
final class SharedBehavior {
private SharedBehavior() {}

static PartitionInfo toPartitionInfo(TopicPath topic, Partition partition) {
return new PartitionInfo(
topic.toString(),
(int) partition.value(),
PubsubLiteNode.NODE,
PubsubLiteNode.NODES,
PubsubLiteNode.NODES);
}

static List<PartitionInfo> partitionsFor(
AdminClient adminClient, TopicPath topic, Duration timeout) {
try {
long count =
adminClient.getTopicPartitionCount(topic).get(timeout.toMillis(), TimeUnit.MILLISECONDS);
ImmutableList.Builder<PartitionInfo> result = ImmutableList.builder();
for (int i = 0; i < count; ++i) {
result.add(toPartitionInfo(topic, Partition.of(i)));
}
return result.build();
} catch (Throwable t) {
throw toKafka(t);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud.pubsublite.kafka;

import static com.google.cloud.pubsublite.internal.testing.UnitTestExamples.example;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.when;
import static org.mockito.MockitoAnnotations.initMocks;

import com.google.api.core.ApiFuture;
import com.google.api.core.ApiFutures;
import com.google.cloud.pubsublite.AdminClient;
import com.google.cloud.pubsublite.TopicPath;
import java.time.Duration;
import java.util.List;
import org.apache.kafka.common.PartitionInfo;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.Mock;

@RunWith(JUnit4.class)
public class SharedBehaviorTest {
@Mock AdminClient admin;

@Before
public void setUp() {
initMocks(this);
}

@Test
public void partitionsForSuccess() throws Exception {
ApiFuture<Long> future = ApiFutures.immediateFuture(2L);
when(admin.getTopicPartitionCount(example(TopicPath.class))).thenReturn(future);
List<PartitionInfo> result =
SharedBehavior.partitionsFor(admin, example(TopicPath.class), Duration.ofDays(1));
assertThat(result.size()).isEqualTo(2);
assertThat(result.get(0).topic()).isEqualTo(example(TopicPath.class).toString());
assertThat(result.get(0).partition()).isEqualTo(0);
assertThat(result.get(0).leader()).isEqualTo(PubsubLiteNode.NODE);
assertThat(result.get(1).topic()).isEqualTo(example(TopicPath.class).toString());
assertThat(result.get(1).partition()).isEqualTo(1);
assertThat(result.get(1).leader()).isEqualTo(PubsubLiteNode.NODE);
}
}

0 comments on commit b42da5f

Please sign in to comment.