Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement Assigner, which delivers partition assignments to a PartitionAssignmentReceiver #133

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

dpcollins-google
Copy link
Collaborator

Diffbased on #132

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #133 into master will decrease coverage by 0.99%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     59.98%   58.98%   -1.00%     
- Complexity      393      394       +1     
============================================
  Files            89       91       +2     
  Lines          2044     2092      +48     
  Branches        173      174       +1     
============================================
+ Hits           1226     1234       +8     
- Misses          723      763      +40     
  Partials         95       95              
Impacted Files Coverage Δ Complexity Δ
...ubsublite/internal/wire/ConnectedAssignerImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/cloud/pubsublite/internal/wire/AssignerImpl.java 38.09% <38.09%> (ø) 1.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e6208...b82e5ed. Read the comment docs.

// SingleConnection implementation.
@Override
protected Status handleInitialResponse(PartitionAssignment response) {
return handleStreamResponse(response);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining that there is no such thing as a PartitionAssignmentInitialResponse? So all responses are treated the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dpcollins-google dpcollins-google merged commit a4485d9 into master Jun 15, 2020
@dpcollins-google dpcollins-google deleted the implement-assigner branch June 15, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants