Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update SingleConnection to not hold the monitor on upcalls #151

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

dpcollins-google
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #151 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
- Coverage     61.18%   61.16%   -0.02%     
  Complexity      417      417              
============================================
  Files            92       92              
  Lines          2146     2145       -1     
  Branches        180      181       +1     
============================================
- Hits           1313     1312       -1     
  Misses          736      736              
  Partials         97       97              
Impacted Files Coverage Δ Complexity Δ
...oud/pubsublite/internal/wire/SingleConnection.java 73.68% <66.66%> (-0.35%) 18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93c9f1...7e4e38c. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 8274753 into master Jun 29, 2020
@dpcollins-google dpcollins-google deleted the dpcollins-google-patch-7 branch June 29, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants