Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update synth.py and run synthtool to get new pubsublite sources. #171

Merged
merged 7 commits into from
Jul 23, 2020

Conversation

dpcollins-google
Copy link
Collaborator

This has the side effect of generating the GAPIC shim. We should consider using this although its unclear if it would give us any benefit.

This has the side effect of generating the GAPIC shim. We should consider using this although its unclear if it would give us any benefit.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@dpcollins-google
Copy link
Collaborator Author

In libraries that have gone GA, breaking changes will require a major version bump.
Even though we allow breaking changes in pre-GA libraries, it's not a great user experience that we want to promote, it shouldn't happen too much too frequently.

In working on this client library, every update to an autogenerated piece of code, whether it is protobufs or autovalue, triggers this check. I don't have a problem with saying "we will not have breaking changes to the user-visible api surface for GA libraries", the problem is the clirr check as it exists does not appear to be sensitive enough to detect those, instead firing on any change to the 'abstract classes' that really only have one implementation created by protobuf and autovalue. If there was a way to make it not trigger on those, I would have no problem leaving it enabled, but it has such a high false positive rate that I don't believe it is worthwhile.

@dpcollins-google dpcollins-google merged commit 90bb70d into master Jul 23, 2020
@dpcollins-google dpcollins-google deleted the synthtool-and-protos branch July 23, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants