Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the TopicStats client #179

Merged
merged 3 commits into from
Jul 31, 2020
Merged

feat: Add the TopicStats client #179

merged 3 commits into from
Jul 31, 2020

Conversation

palmere-google
Copy link
Contributor

@palmere-google palmere-google commented Jul 30, 2020

Adds an interface and implementation for the TopicStatsClient. I've kept
them both in internal for now since we don't yet expose an API for
interacting with the CursorService.

Adds an interface and implementation for the TopicStatsClient. I've kept
them both in internal for now since we don't yet expose an API for
interacting with the CursorService.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #179 into master will decrease coverage by 0.18%.
The diff coverage is 68.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
- Coverage     64.21%   64.02%   -0.19%     
- Complexity      643      650       +7     
============================================
  Files           128      133       +5     
  Lines          3831     3886      +55     
  Branches        198      198              
============================================
+ Hits           2460     2488      +28     
- Misses         1260     1287      +27     
  Partials        111      111              
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/pubsublite/AdminClientSettings.java 0.00% <0.00%> (-34.79%) 0.00 <0.00> (-1.00)
...le/cloud/pubsublite/internal/TopicStatsClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../pubsublite/internal/TopicStatsClientSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...loud/pubsublite/internal/TopicStatsClientImpl.java 70.00% <70.00%> (ø) 7.00 <7.00> (?)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 90.90% <91.66%> (-0.86%) 24.00 <10.00> (-4.00)
...in/java/com/google/cloud/pubsublite/Constants.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...loud/pubsublite/internal/RetryingExecutorUtil.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c4f79...b4ebce0. Read the comment docs.

Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm. make the requested changes (most of them surrounding code reuse) then ping me again before merging if you could.

@dpcollins-google dpcollins-google self-requested a review July 30, 2020 20:29
@dpcollins-google dpcollins-google dismissed their stale review July 30, 2020 20:30

trying to remove approval

@palmere-google
Copy link
Contributor Author

PTAL

Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the one nit?

@palmere-google palmere-google merged commit 7eb7861 into master Jul 31, 2020
@palmere-google palmere-google deleted the topic-stats branch July 31, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants