feat: Add the TopicStats client#179
Merged
palmere-google merged 3 commits intomasterfrom Jul 31, 2020
Merged
Conversation
Adds an interface and implementation for the TopicStatsClient. I've kept them both in internal for now since we don't yet expose an API for interacting with the CursorService.
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
============================================
- Coverage 64.21% 64.02% -0.19%
- Complexity 643 650 +7
============================================
Files 128 133 +5
Lines 3831 3886 +55
Branches 198 198
============================================
+ Hits 2460 2488 +28
- Misses 1260 1287 +27
Partials 111 111
Continue to review full report at Codecov.
|
dpcollins-google
previously approved these changes
Jul 30, 2020
Collaborator
dpcollins-google
left a comment
There was a problem hiding this comment.
Mostly lgtm. make the requested changes (most of them surrounding code reuse) then ping me again before merging if you could.
...le-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClient.java
Show resolved
Hide resolved
...loud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientImpl.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientSettings.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientSettings.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/test/java/com/google/cloud/pubsublite/internal/TopicStatsClientImplTest.java
Show resolved
Hide resolved
Contributor
Author
|
PTAL |
dpcollins-google
approved these changes
Jul 31, 2020
Collaborator
dpcollins-google
left a comment
There was a problem hiding this comment.
LGTM, please fix the one nit?
google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/AdminClientSettings.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an interface and implementation for the TopicStatsClient. I've kept
them both in internal for now since we don't yet expose an API for
interacting with the CursorService.