fix: add clirr ignored diffs files#184
Merged
anguillanneuf merged 9 commits intomasterfrom Aug 3, 2020
Merged
Conversation
google-cla
bot
added
the
cla: yes
hannahrogers-google
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
anguillanneuf
approved these changes
Jul 31, 2020
Contributor
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
Thank you! Samples tests fail because we hit a quota limit in us-central1-b. I can update test to not always pick the same zone when tests are run.
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=========================================
Coverage 64.02% 64.02%
Complexity 650 650
=========================================
Files 133 133
Lines 3886 3886
Branches 198 198
=========================================
Hits 2488 2488
Misses 1287 1287
Partials 111 111
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am ignoring the most common failures in the internal folders and the beam folder. I also added an ignored diffs file for our protos.
Fixes #178