Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add clirr ignored diffs files #184

Merged
merged 9 commits into from
Aug 3, 2020
Merged

fix: add clirr ignored diffs files #184

merged 9 commits into from
Aug 3, 2020

Conversation

hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Jul 31, 2020

I am ignoring the most common failures in the internal folders and the beam folder. I also added an ignored diffs file for our protos.

Fixes #178

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Samples tests fail because we hit a quota limit in us-central1-b. I can update test to not always pick the same zone when tests are run.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #184   +/-   ##
=========================================
  Coverage     64.02%   64.02%           
  Complexity      650      650           
=========================================
  Files           133      133           
  Lines          3886     3886           
  Branches        198      198           
=========================================
  Hits           2488     2488           
  Misses         1287     1287           
  Partials        111      111           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/pubsublite/Stubs.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb7861...0c124ad. Read the comment docs.

@anguillanneuf anguillanneuf merged commit 0122757 into master Aug 3, 2020
@anguillanneuf anguillanneuf deleted the ignored-diffs branch August 3, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable clirr to unblock Maven releases
3 participants