Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement DefaultRoutingPolicyTest #188

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

dpcollins-google
Copy link
Collaborator

This has a fixed set of test cases to ensure that all client libraries route the same keys to the same partitions.

…t cases to ensure that all client libraries route the same keys to the same partitions.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Aug 21, 2020
@dpcollins-google
Copy link
Collaborator Author

WANT_LGTM=any

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #188 into master will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     64.02%   63.34%   -0.68%     
- Complexity      650      652       +2     
============================================
  Files           133      134       +1     
  Lines          3886     3959      +73     
  Branches        198      201       +3     
============================================
+ Hits           2488     2508      +20     
- Misses         1287     1338      +51     
- Partials        111      113       +2     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/pubsublite/Stubs.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...oud/pubsublite/cloudpubsub/SubscriberSettings.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ubsublite/v1/PartitionAssignmentServiceClient.java 34.78% <0.00%> (ø) 4.00% <0.00%> (ø%)
...loud/pubsublite/internal/wire/AssignerBuilder.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...d/pubsublite/v1/stub/AdminServiceStubSettings.java 80.08% <0.00%> (+0.17%) 21.00% <0.00%> (ø%)
.../pubsublite/v1/stub/CursorServiceStubSettings.java 77.77% <0.00%> (+0.41%) 12.00% <0.00%> (ø%)
...sublite/v1/stub/TopicStatsServiceStubSettings.java 78.20% <0.00%> (+0.57%) 10.00% <0.00%> (ø%)
...bsublite/v1/stub/PublisherServiceStubSettings.java 77.77% <0.00%> (+0.63%) 10.00% <0.00%> (ø%)
...sublite/v1/stub/SubscriberServiceStubSettings.java 77.77% <0.00%> (+0.63%) 10.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78e46c...2351adb. Read the comment docs.

@dpcollins-google dpcollins-google merged commit fa49931 into master Aug 21, 2020
@dpcollins-google dpcollins-google deleted the default_routing_policy_test branch August 21, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants