Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: update samples for automatic subscriber assignment #189

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

anguillanneuf
Copy link
Contributor

Create PR after #163 is merged and published on Maven Central.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@anguillanneuf anguillanneuf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 5, 2020
@dpcollins-google dpcollins-google marked this pull request as ready for review August 11, 2020 14:18
@dpcollins-google
Copy link
Collaborator

This all LGTM. Going to get the auto-assignment stuff on maven central today, then this should be submittable. If I could figure out how to approve I would, but it won't seem to let me.

Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Looks good, thanks for also picking up the storage size changes

@anguillanneuf anguillanneuf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 11, 2020
@anguillanneuf anguillanneuf merged commit 945f775 into master Aug 11, 2020
@anguillanneuf anguillanneuf deleted the samples-subscriber branch August 11, 2020 16:04
@release-please release-please bot mentioned this pull request Aug 12, 2020
@release-please release-please bot mentioned this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants