samples: update samples for automatic subscriber assignment#189
Merged
anguillanneuf merged 2 commits intomasterfrom Aug 11, 2020
Merged
samples: update samples for automatic subscriber assignment#189anguillanneuf merged 2 commits intomasterfrom
anguillanneuf merged 2 commits intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
anguillanneuf
added
the
do not merge
Collaborator
|
This all LGTM. Going to get the auto-assignment stuff on maven central today, then this should be submittable. If I could figure out how to approve I would, but it won't seem to let me. |
dpcollins-google
approved these changes
Aug 11, 2020
Collaborator
dpcollins-google
left a comment
dpcollins-google
left a comment
There was a problem hiding this comment.
Approved! Looks good, thanks for also picking up the storage size changes
anguillanneuf
removed
the
do not merge
anguillanneuf
added a commit
that referenced
this pull request
Aug 11, 2020
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create PR after #163 is merged and published on Maven Central.