Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve test coverage for internal/wire folder. #214

Merged
merged 8 commits into from
Aug 21, 2020

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #214 into master will increase coverage by 4.63%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
+ Coverage     63.14%   67.78%   +4.63%     
- Complexity      650      692      +42     
============================================
  Files           134      134              
  Lines          3959     3970      +11     
  Branches        201      201              
============================================
+ Hits           2500     2691     +191     
+ Misses         1348     1164     -184     
- Partials        111      115       +4     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/pubsublite/internal/ChannelCache.java 64.70% <80.00%> (+64.70%) 4.00 <1.00> (+4.00)
...internal/wire/SinglePartitionPublisherBuilder.java 100.00% <100.00%> (+100.00%) 2.00 <1.00> (+2.00)
...oogle/cloud/pubsublite/internal/wire/Versions.java 90.47% <100.00%> (+52.97%) 8.00 <7.00> (+4.00)
...cloud/pubsublite/internal/wire/SubscriberImpl.java 84.32% <0.00%> (+1.49%) 27.00% <0.00%> (+1.00%)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 79.83% <0.00%> (+1.68%) 21.00% <0.00%> (+1.00%)
...google/cloud/pubsublite/internal/ProxyService.java 83.33% <0.00%> (+1.85%) 11.00% <0.00%> (ø%)
.../cloud/pubsublite/internal/wire/CommitterImpl.java 69.38% <0.00%> (+4.08%) 9.00% <0.00%> (+1.00%)
...sublite/internal/wire/ConnectedSubscriberImpl.java 90.32% <0.00%> (+22.58%) 18.00% <0.00%> (+4.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a276b...55bb19d. Read the comment docs.

@dpcollins-google dpcollins-google merged commit db2bc7a into master Aug 21, 2020
@dpcollins-google dpcollins-google deleted the test_coverage branch August 21, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants