Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update samples for v0.3.0 #235

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     72.94%   72.94%           
  Complexity      751      751           
=========================================
  Files           135      135           
  Lines          3977     3977           
  Branches        208      208           
=========================================
  Hits           2901     2901           
  Misses          953      953           
  Partials        123      123           
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/pubsublite/internal/AdminClientImpl.java 88.99% <0.00%> (ø) 24.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1f557...2c5475b. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Sep 8, 2020
Copy link
Contributor

@manuelmenzella-google manuelmenzella-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tianzi may be interested in these changes.

Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - for java-sample-reviewers
I like the changes to the API, but wonder about using the project Number instead of the more common projectName.
You might wish to check the warnings from CodeCov - as the changes it calls out as not being covered seem like important parts of the sample.

.setZone(CloudZone.of(CloudRegion.of(cloudRegion), zoneId))
.setTopicName(TopicName.of(topicId))
TopicPath.newBuilder()
.setProject(ProjectNumber.of(projectNumber))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we use projectName everywhere else in cloud?

@dpcollins-google dpcollins-google merged commit 61b1981 into master Sep 8, 2020
@dpcollins-google dpcollins-google deleted the update-samples-2 branch September 8, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants