Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix BufferingPullSubscriber to not seek after sending flow control tokens. #253

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

dpcollins-google
Copy link
Collaborator

Seeking after sending tokens will discard any flow control tokens sent to the server. Also, update BufferingPullSubscriber to accept arbitrary initial seek requests.

…ol tokens.

Seeking after sending tokens will discard any flow control tokens sent to the server. Also, update BufferingPullSubscriber to accept arbitrary initial seek requests.
@dpcollins-google dpcollins-google requested a review from a team as a code owner September 24, 2020 14:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #253 into master will decrease coverage by 0.15%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #253      +/-   ##
============================================
- Coverage     72.74%   72.59%   -0.16%     
  Complexity      759      759              
============================================
  Files           135      135              
  Lines          4033     4032       -1     
  Branches        213      212       -1     
============================================
- Hits           2934     2927       -7     
- Misses          975      981       +6     
  Partials        124      124              
Impacted Files Coverage Δ Complexity Δ
...oud/pubsublite/beam/PubsubLiteUnboundedSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...d/pubsublite/internal/BufferingPullSubscriber.java 82.05% <70.00%> (-8.65%) 4.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4111f09...61274f5. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 0e20d80 into master Sep 24, 2020
@dpcollins-google dpcollins-google deleted the fix_buffering_pull_subscriber branch September 24, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants