Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nextOffset method to BufferingPullSubscriber #272

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

dpcollins-google
Copy link
Collaborator

feat: Add nextOffset method to BufferingPullSubscriber

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 2, 2020 17:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #272 into master will decrease coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
- Coverage     72.43%   71.80%   -0.64%     
- Complexity      771      776       +5     
============================================
  Files           140      141       +1     
  Lines          4096     4146      +50     
  Branches        215      214       -1     
============================================
+ Hits           2967     2977      +10     
- Misses         1004     1044      +40     
  Partials        125      125              
Impacted Files Coverage Δ Complexity Δ
...d/pubsublite/internal/BufferingPullSubscriber.java 85.71% <100.00%> (+3.66%) 8.00 <7.00> (+4.00)
...ogle/cloud/pubsublite/internal/FakeApiService.java
...ud/pubsublite/internal/testing/FakeApiService.java 100.00% <0.00%> (ø) 4.00% <0.00%> (?%)
.../pubsublite/internal/testing/UnitTestExamples.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4005fcd...2330eb1. Read the comment docs.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 3, 2020
@dpcollins-google dpcollins-google merged commit 5c0e7cc into master Oct 5, 2020
@dpcollins-google dpcollins-google deleted the buffering-pull-sub-update branch October 5, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants