feat: Add pubsublite-kafka-shim directory and disable deployment#273
Merged
dpcollins-google merged 2 commits intomasterfrom Oct 2, 2020
Merged
feat: Add pubsublite-kafka-shim directory and disable deployment#273dpcollins-google merged 2 commits intomasterfrom
dpcollins-google merged 2 commits intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
chingor13
approved these changes
Oct 2, 2020
pubsublite-kafka-shim/pom.xml
Outdated
Comment on lines
35
to
46
Contributor
There was a problem hiding this comment.
nit: renovate might propose 2 PRs to update truth if they are specified separately
Collaborator
Author
There was a problem hiding this comment.
Good to know for the future. I'll try to move the truth version number to the parent, or remove it if its in common deps now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add pubsublite-kafka-shim directory and disable deployment