Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pubsublite-kafka-shim directory and disable deployment #273

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

dpcollins-google
Copy link
Collaborator

feat: Add pubsublite-kafka-shim directory and disable deployment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
Comment on lines 35 to 46
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<version>1.0.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.truth.extensions</groupId>
<artifactId>truth-java8-extension</artifactId>
<version>1.0.1</version>
<scope>test</scope>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: renovate might propose 2 PRs to update truth if they are specified separately

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know for the future. I'll try to move the truth version number to the parent, or remove it if its in common deps now.

@dpcollins-google dpcollins-google merged commit 8bf29f8 into master Oct 2, 2020
@dpcollins-google dpcollins-google deleted the kafka-maven branch October 2, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants