Skip to content

feat: Add SharedBehavior class which handles the PartitionsFor method on consumers and producers#278

Merged
dpcollins-google merged 7 commits intomasterfrom
shared-behavior
Oct 5, 2020
Merged

feat: Add SharedBehavior class which handles the PartitionsFor method on consumers and producers#278
dpcollins-google merged 7 commits intomasterfrom
shared-behavior

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Oct 5, 2020

Diffbased on #276

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 5, 2020 12:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #278 into master will decrease coverage by 0.88%.
The diff coverage is 42.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     71.80%   70.92%   -0.89%     
- Complexity      775      780       +5     
============================================
  Files           141      146       +5     
  Lines          4146     4244      +98     
  Branches        215      217       +2     
============================================
+ Hits           2977     3010      +33     
- Misses         1044     1107      +63     
- Partials        125      127       +2     
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/kafka/KafkaExceptionUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...oogle/cloud/pubsublite/internal/ExtractStatus.java 44.44% <30.43%> (-33.34%) 4.00 <1.00> (-2.00)
...com/google/cloud/pubsublite/kafka/LiteHeaders.java 34.78% <34.78%> (ø) 4.00 <4.00> (?)
.../google/cloud/pubsublite/kafka/SharedBehavior.java 81.81% <81.81%> (ø) 3.00 <3.00> (?)
...oogle/cloud/pubsublite/kafka/RecordTransforms.java 84.61% <84.61%> (ø) 3.00 <3.00> (?)
.../google/cloud/pubsublite/kafka/PubsubLiteNode.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...d/pubsublite/internal/BufferingPullSubscriber.java 82.05% <0.00%> (-3.67%) 4.00% <0.00%> (-4.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c43ef3...32a615e. Read the comment docs.

@dpcollins-google dpcollins-google merged commit b42da5f into master Oct 5, 2020
@dpcollins-google dpcollins-google deleted the shared-behavior branch October 5, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants