Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement PubsubLiteConsumer. #287

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Conversation

dpcollins-google
Copy link
Collaborator

This implements Kafka's Consumer API.

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 8, 2020 18:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #287 into master will increase coverage by 9.50%.
The diff coverage is 61.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
+ Coverage     61.68%   71.19%   +9.50%     
+ Complexity      984      892      -92     
============================================
  Files           189      151      -38     
  Lines          6063     4735    -1328     
  Branches        525      236     -289     
============================================
- Hits           3740     3371     -369     
+ Misses         2017     1230     -787     
+ Partials        306      134     -172     
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsublite/kafka/ConsumerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...gle/cloud/pubsublite/kafka/PubsubLiteConsumer.java 70.85% <70.85%> (ø) 53.00 <53.00> (?)
...blite/internal/AutoValue_CursorClientSettings.java
...l/wire/AutoOneOf_ConnectedSubscriber_Response.java
...ite/beam/AutoValue_TopicBacklogReaderSettings.java
...le/cloud/pubsublite/AutoValue_PublishMetadata.java
...loud/pubsublite/AutoValue_AdminClientSettings.java
...teUnboundedReader_PartitionedSequencedMessage.java
...com/google/cloud/pubsublite/AutoValue_Message.java
...m/google/cloud/pubsublite/beam/AutoValue_Uuid.java
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e409c2...7eefca7. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 9, 2020
Copy link
Contributor

@manuelmenzella-google manuelmenzella-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Thanks.

@dpcollins-google dpcollins-google merged commit eed9656 into master Oct 12, 2020
@dpcollins-google dpcollins-google deleted the multi-consumer branch October 12, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants