feat: Implement PubsubLiteConsumer.#287
Merged
dpcollins-google merged 3 commits intomasterfrom Oct 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
============================================
+ Coverage 61.68% 71.19% +9.50%
+ Complexity 984 892 -92
============================================
Files 189 151 -38
Lines 6063 4735 -1328
Branches 525 236 -289
============================================
- Hits 3740 3371 -369
+ Misses 2017 1230 -787
+ Partials 306 134 -172 Continue to review full report at Codecov.
|
manuelmenzella-google
approved these changes
Oct 12, 2020
Contributor
manuelmenzella-google
left a comment
There was a problem hiding this comment.
Minor nits. Thanks.
pubsublite-kafka-shim/src/main/java/com/google/cloud/pubsublite/kafka/PubsubLiteConsumer.java
Outdated
Show resolved
Hide resolved
pubsublite-kafka-shim/src/main/java/com/google/cloud/pubsublite/kafka/PubsubLiteConsumer.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Kafka's Consumer API.