Skip to content

fix: Make connections start up asynchronously#289

Merged
dpcollins-google merged 7 commits intomasterfrom
async-startup
Oct 12, 2020
Merged

fix: Make connections start up asynchronously#289
dpcollins-google merged 7 commits intomasterfrom
async-startup

Conversation

@dpcollins-google
Copy link
Collaborator

This lets publishers initialize many connections at once for lower startup times with many partitions.

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 9, 2020 16:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #289 into master will increase coverage by 10.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #289       +/-   ##
=============================================
+ Coverage     61.68%   71.82%   +10.14%     
+ Complexity      984      840      -144     
=============================================
  Files           189      149       -40     
  Lines          6063     4458     -1605     
  Branches        525      196      -329     
=============================================
- Hits           3740     3202      -538     
+ Misses         2017     1133      -884     
+ Partials        306      123      -183     
Impacted Files Coverage Δ Complexity Δ
...bsublite/internal/wire/RetryingConnectionImpl.java 69.04% <100.00%> (+3.16%) 13.00 <2.00> (+1.00)
...google/cloud/pubsublite/v1/AdminServiceClient.java 64.94% <0.00%> (-3.45%) 39.00% <0.00%> (ø%)
...oogle/cloud/pubsublite/v1/CursorServiceClient.java 60.00% <0.00%> (-2.00%) 9.00% <0.00%> (ø%)
...e/cloud/pubsublite/internal/wire/AssignerImpl.java 76.00% <0.00%> (-0.93%) 7.00% <0.00%> (ø%)
.../cloud/pubsublite/internal/wire/CommitterImpl.java 68.75% <0.00%> (-0.64%) 9.00% <0.00%> (ø%)
...cloud/pubsublite/internal/wire/SubscriberImpl.java 84.21% <0.00%> (-0.12%) 27.00% <0.00%> (ø%)
...oud/pubsublite/beam/PubsubLiteUnboundedReader.java 74.16% <0.00%> (ø) 24.00% <0.00%> (ø%)
...le/cloud/pubsublite/AutoValue_PublishMetadata.java
...m/google/cloud/pubsublite/AutoValue_TopicName.java
...loud/pubsublite/AutoValue_AdminClientSettings.java
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e409c2...c0cf346. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 27b1fec into master Oct 12, 2020
@dpcollins-google dpcollins-google deleted the async-startup branch October 12, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants