Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change internals to throw StatusException instead of return Status #300

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

dpcollins-google
Copy link
Collaborator

This is an intermediate change needed to move to ApiException/CheckedApiException.

This is an intermediate change needed to move to ApiException/CheckedApiException.
@dpcollins-google dpcollins-google requested a review from a team as a code owner October 19, 2020 17:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #300 into master will increase coverage by 0.15%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     71.16%   71.32%   +0.15%     
+ Complexity      893      882      -11     
============================================
  Files           151      151              
  Lines          4738     4740       +2     
  Branches        236      226      -10     
============================================
+ Hits           3372     3381       +9     
  Misses         1232     1232              
+ Partials        134      127       -7     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/pubsublite/internal/wire/AssignerImpl.java 82.60% <ø> (+5.68%) 7.00 <0.00> (ø)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 82.35% <42.85%> (+2.52%) 21.00 <0.00> (ø)
...ubsublite/internal/wire/ConnectedAssignerImpl.java 92.00% <50.00%> (-0.60%) 5.00 <1.00> (ø)
...cloud/pubsublite/internal/wire/SubscriberImpl.java 84.37% <64.28%> (+0.04%) 26.00 <2.00> (-1.00) ⬆️
...loudpubsub/internal/SinglePartitionSubscriber.java 86.27% <75.00%> (-7.06%) 5.00 <1.00> (ø)
...bsublite/internal/wire/ConnectedCommitterImpl.java 96.00% <88.88%> (+8.00%) 4.00 <2.00> (-2.00) ⬆️
...sublite/internal/wire/ConnectedSubscriberImpl.java 89.39% <89.28%> (-0.93%) 14.00 <3.00> (-4.00)
...d/pubsublite/internal/wire/BatchPublisherImpl.java 100.00% <100.00%> (+10.71%) 8.00 <3.00> (-1.00) ⬆️
...le/cloud/pubsublite/internal/wire/CommitState.java 93.75% <100.00%> (+0.20%) 13.00 <0.00> (ø)
.../cloud/pubsublite/internal/wire/CommitterImpl.java 70.00% <100.00%> (+0.61%) 9.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18ea58...5232de9. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 96ad02c into master Oct 19, 2020
@dpcollins-google dpcollins-google deleted the status-to-exc branch October 19, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants