Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement ApiResourceAggregation to deduplicate logic for BackgroundResources. #301

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 19, 2020 18:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.28%.
The diff coverage is 64.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #301      +/-   ##
============================================
+ Coverage     71.01%   71.29%   +0.28%     
+ Complexity      893      892       -1     
============================================
  Files           151      152       +1     
  Lines          4733     4727       -6     
  Branches        235      236       +1     
============================================
+ Hits           3361     3370       +9     
+ Misses         1231     1223       -8     
+ Partials        141      134       -7     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/pubsublite/AdminClient.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...google/cloud/pubsublite/internal/CursorClient.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...le/cloud/pubsublite/internal/TopicStatsClient.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ud/pubsublite/internal/ApiResourceAggregation.java 40.00% <40.00%> (ø) 3.00 <3.00> (?)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 88.88% <100.00%> (ø) 24.00 <1.00> (ø)
...le/cloud/pubsublite/internal/CursorClientImpl.java 100.00% <100.00%> (+20.93%) 8.00 <1.00> (-2.00) ⬆️
...loud/pubsublite/internal/TopicStatsClientImpl.java 100.00% <100.00%> (+30.00%) 5.00 <2.00> (-2.00) ⬆️
.../google/cloud/pubsublite/PartitionLookupUtils.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ud/pubsublite/beam/TopicBacklogReaderSettings.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ad02c...1ad999b. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 09578b5 into master Oct 19, 2020
@dpcollins-google dpcollins-google deleted the api-background branch October 19, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants