Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement TopicConfigWatcher #377

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Conversation

palmere-google
Copy link
Contributor

The topic config watcher polls the topic config and calls an update handler whenever the config cahnges

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner November 18, 2020 18:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Nov 18, 2020
Comment on lines 20 to 22

import java.time.Duration;
import java.util.function.Consumer;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.time.Duration;
import java.util.function.Consumer;
interface Factory {
TopicConfigWatcher New(Consumer<Topic> receiver, Duration period);
}

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #377 (af47585) into master (1b1e14c) will increase coverage by 0.23%.
The diff coverage is 95.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #377      +/-   ##
============================================
+ Coverage     72.15%   72.39%   +0.23%     
- Complexity      772      782      +10     
============================================
  Files           147      148       +1     
  Lines          4148     4191      +43     
  Branches        202      205       +3     
============================================
+ Hits           2993     3034      +41     
- Misses         1040     1042       +2     
  Partials        115      115              
Impacted Files Coverage Δ Complexity Δ
...blite/internal/wire/PartitionCountWatcherImpl.java 95.34% <95.34%> (ø) 10.00 <10.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1e14c...af47585. Read the comment docs.

@palmere-google palmere-google merged commit b98c501 into master Nov 19, 2020
@palmere-google palmere-google deleted the increase_partitions branch November 19, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants