Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PSL spark sql streaming utility classes #391

Merged
merged 9 commits into from
Dec 3, 2020

Conversation

jiangmichaellll
Copy link
Contributor

Spark sql streaming POJOs and utility classes.

Also making com.google.cloud.pubsublite.Offset serializable, as it's needed for serialization into executor later.

@jiangmichaellll jiangmichaellll requested review from a team as code owners December 1, 2020 04:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #391 (cdab064) into master (a15ed0b) will decrease coverage by 1.40%.
The diff coverage is 22.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
- Coverage     72.39%   70.98%   -1.41%     
- Complexity      783      796      +13     
============================================
  Files           148      154       +6     
  Lines          4191     4312     +121     
  Branches        204      210       +6     
============================================
+ Hits           3034     3061      +27     
- Misses         1042     1134      +92     
- Partials        115      117       +2     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/pubsublite/spark/Constants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cloud/pubsublite/spark/PslCredentialsProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/cloud/pubsublite/spark/PslDataSourceOptions.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...google/cloud/pubsublite/spark/PslSourceOffset.java 77.41% <77.41%> (ø) 11.00 <11.00> (?)
.../main/java/com/google/cloud/pubsublite/Offset.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...gle/cloud/pubsublite/spark/PslPartitionOffset.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15ed0b...d237959. Read the comment docs.

@jiangmichaellll jiangmichaellll merged commit 0e4cb93 into master Dec 3, 2020
@jiangmichaellll jiangmichaellll deleted the jiangmichael-spark-utils branch December 3, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants