Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attempt to start the publisher and publish in the ITVPC test #420

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

palmere-google
Copy link
Contributor

Now that we don't call the admin api on publisher creation, we need to start the publisher to get an error in the VPCSC test

@palmere-google palmere-google requested a review from a team as a code owner December 11, 2020 03:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #420 (399d873) into master (0c0d928) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage     71.25%   71.25%           
  Complexity      867      867           
=========================================
  Files           163      163           
  Lines          4574     4574           
  Branches        226      226           
=========================================
  Hits           3259     3259           
  Misses         1188     1188           
  Partials        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0d928...399d873. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 8ebc9f1 into master Dec 11, 2020
@dpcollins-google dpcollins-google deleted the palmere-fix-test branch December 11, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants