Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spark micro batch processing #426

Merged
merged 48 commits into from
Dec 16, 2020

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll commented Dec 14, 2020

Implementation of spark micro batch processing. Many parts are similar to continuous processing.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner December 14, 2020 22:08
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 14, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2020
Copy link

@yoshi-code-bot yoshi-code-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pubsublite-spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/PslDataSource.java
    • lines 37-38

Copy link

@yoshi-code-bot yoshi-code-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pubsublite-spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/PslDataSource.java
    • lines 37-38

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #426 (676a9fb) into master (36684c4) will decrease coverage by 0.58%.
The diff coverage is 48.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #426      +/-   ##
============================================
- Coverage     71.60%   71.01%   -0.59%     
- Complexity      876      898      +22     
============================================
  Files           164      167       +3     
  Lines          4613     4733     +120     
  Branches        234      240       +6     
============================================
+ Hits           3303     3361      +58     
- Misses         1179     1234      +55     
- Partials        131      138       +7     
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/pubsublite/spark/PslDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...le/cloud/pubsublite/spark/PslContinuousReader.java 54.28% <40.00%> (-7.42%) 8.00 <0.00> (-2.00)
.../pubsublite/spark/PslMicroBatchInputPartition.java 40.00% <40.00%> (ø) 1.00 <1.00> (?)
...blite/spark/PslMicroBatchInputPartitionReader.java 62.85% <62.85%> (ø) 7.00 <7.00> (?)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 69.76% <69.76%> (ø) 12.00 <12.00> (?)
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 90.69% <81.81%> (-3.06%) 9.00 <2.00> (+2.00) ⬇️
...e/cloud/pubsublite/spark/SparkPartitionOffset.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36684c4...676a9fb. Read the comment docs.

@jiangmichaellll jiangmichaellll merged commit 86aecc9 into master Dec 16, 2020
@jiangmichaellll jiangmichaellll deleted the jiangmichael-spark-micro-batch branch December 16, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants