Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extract the rpc exception from IllegalStateExceptions in publish/… #430

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

palmere-google
Copy link
Contributor

…subscribe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner December 16, 2020 18:06
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 16, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #430 (e0b06ef) into master (e56d2c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #430   +/-   ##
=========================================
  Coverage     71.60%   71.60%           
  Complexity      877      877           
=========================================
  Files           164      164           
  Lines          4613     4613           
  Branches        233      233           
=========================================
  Hits           3303     3303           
  Misses         1179     1179           
  Partials        131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56d2c2...ea11f06. Read the comment docs.

@palmere-google palmere-google changed the title fix: Extract the rpc exception from IllegalStateExceptins in publish/… fix: Extract the rpc exception from IllegalStateExceptions in publish/… Dec 16, 2020
@palmere-google palmere-google merged commit ff05b1a into master Dec 16, 2020
@palmere-google palmere-google deleted the palmere-vpcsc branch December 16, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants