Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding a method to the internal wire publisher that will attempt to cancel all outstanding publishes #434

Merged
merged 12 commits into from
Dec 22, 2020

Conversation

hannahrogers-google
Copy link
Contributor

No description provided.

@hannahrogers-google hannahrogers-google requested a review from a team as a code owner December 21, 2020 23:47
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 21, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #434 (d2ae03d) into master (9df4ccf) will increase coverage by 0.09%.
The diff coverage is 85.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #434      +/-   ##
============================================
+ Coverage     71.22%   71.32%   +0.09%     
- Complexity      905      913       +8     
============================================
  Files           167      167              
  Lines          4789     4812      +23     
  Branches        242      244       +2     
============================================
+ Hits           3411     3432      +21     
- Misses         1240     1241       +1     
- Partials        138      139       +1     
Impacted Files Coverage Δ Complexity Δ
...ubsublite/internal/wire/ApiExceptionPublisher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...internal/wire/PartitionCountWatchingPublisher.java 97.08% <80.00%> (-1.84%) 18.00 <1.00> (+1.00) ⬇️
.../cloud/pubsublite/internal/wire/PublisherImpl.java 83.47% <100.00%> (+0.71%) 24.00 <4.00> (+3.00)
...oud/pubsublite/internal/wire/RoutingPublisher.java 95.45% <100.00%> (+1.01%) 6.00 <2.00> (+2.00)
...ublite/internal/wire/SinglePartitionPublisher.java 100.00% <100.00%> (+20.00%) 5.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df4ccf...d2ae03d. Read the comment docs.

@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 22, 2020
@hannahrogers-google hannahrogers-google merged commit 7b9776e into googleapis:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants