Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove per-message byte limit in client #435

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

dpcollins-google
Copy link
Collaborator

There still exists a 3.5MiB byte limit server side, and a protocol level 4MiB message limit.

There still exists a 3.5MiB byte limit server side, and a protocol level 4MiB message limit.
@dpcollins-google dpcollins-google requested a review from a team as a code owner December 22, 2020 15:01
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #435 (c7d9d52) into master (9df4ccf) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
+ Coverage     71.22%   71.34%   +0.11%     
- Complexity      905      906       +1     
============================================
  Files           167      167              
  Lines          4789     4781       -8     
  Branches        242      239       -3     
============================================
  Hits           3411     3411              
+ Misses         1240     1233       -7     
+ Partials        138      137       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/pubsublite/Constants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 88.88% <ø> (+6.13%) 21.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df4ccf...311f6fd. Read the comment docs.

@dpcollins-google dpcollins-google requested a review from a team as a code owner January 12, 2021 14:49
@dpcollins-google dpcollins-google merged commit f7f36eb into master Jan 12, 2021
@dpcollins-google dpcollins-google deleted the remove_per_message_limit branch January 12, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants