Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add non google default creds provider to subscribers in Spark Connector #440

Merged
merged 4 commits into from
Jan 9, 2021

Conversation

jiangmichaellll
Copy link
Contributor

As titled.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner January 5, 2021 21:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 5, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #440 (0f59698) into master (5190989) will decrease coverage by 0.23%.
The diff coverage is 4.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #440      +/-   ##
============================================
- Coverage     71.32%   71.08%   -0.24%     
  Complexity      913      913              
============================================
  Files           167      167              
  Lines          4812     4831      +19     
  Branches        244      244              
============================================
+ Hits           3432     3434       +2     
- Misses         1241     1257      +16     
- Partials        139      140       +1     
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/pubsublite/AdminClientSettings.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...loud/pubsublite/internal/CursorClientSettings.java 41.66% <ø> (ø) 3.00 <0.00> (ø)
.../pubsublite/internal/TopicStatsClientSettings.java 41.66% <ø> (ø) 3.00 <0.00> (ø)
...loud/pubsublite/internal/wire/AssignerBuilder.java 65.38% <ø> (ø) 3.00 <0.00> (ø)
...oud/pubsublite/internal/wire/CommitterBuilder.java 52.63% <ø> (ø) 2.00 <0.00> (ø)
...oud/pubsublite/internal/wire/PublisherBuilder.java 68.75% <0.00%> (+6.48%) 3.00 <0.00> (ø)
...loud/pubsublite/internal/wire/RoutingMetadata.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...cloud/pubsublite/internal/wire/ServiceClients.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ud/pubsublite/internal/wire/SubscriberBuilder.java 47.82% <0.00%> (+7.08%) 2.00 <0.00> (ø)
.../pubsublite/spark/PslContinuousInputPartition.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5190989...0f59698. Read the comment docs.

Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix changes then LGTM

@jiangmichaellll jiangmichaellll merged commit 2099751 into master Jan 9, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-spark-creds branch January 9, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants