Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix bug where blockingpullsubscriber doesn't refill flowcontrol quota. #449

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll commented Jan 12, 2021

As titled.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner January 12, 2021 03:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #449 (71f4e36) into master (f484754) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     71.06%   71.10%   +0.03%     
+ Complexity      918      917       -1     
============================================
  Files           168      168              
  Lines          4866     4872       +6     
  Branches        244      245       +1     
============================================
+ Hits           3458     3464       +6     
  Misses         1268     1268              
  Partials        140      140              
Impacted Files Coverage Δ Complexity Δ
...ubsublite/internal/BlockingPullSubscriberImpl.java 87.93% <100.00%> (+1.39%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f484754...fe3e9b7. Read the comment docs.

@jiangmichaellll jiangmichaellll merged commit 109bd83 into master Jan 12, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-spark-refill branch January 12, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants