Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed assert to Preconditions check #457

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

jiangmichaellll
Copy link
Contributor

As titled.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner January 13, 2021 21:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #457 (a97ba26) into master (d1c2a24) will increase coverage by 0.32%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #457      +/-   ##
============================================
+ Coverage     71.14%   71.47%   +0.32%     
+ Complexity      917      913       -4     
============================================
  Files           168      168              
  Lines          4873     4876       +3     
  Branches        245      239       -6     
============================================
+ Hits           3467     3485      +18     
- Misses         1268     1269       +1     
+ Partials        138      122      -16     
Impacted Files Coverage Δ Complexity Δ
.../pubsublite/spark/PslContinuousInputPartition.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...blite/spark/PslContinuousInputPartitionReader.java 70.37% <50.00%> (+6.08%) 5.00 <1.00> (ø)
...blite/spark/PslMicroBatchInputPartitionReader.java 67.64% <50.00%> (+4.78%) 7.00 <1.00> (ø)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 88.88% <87.50%> (+7.93%) 11.00 <4.00> (-1.00) ⬆️
...le/cloud/pubsublite/spark/PslContinuousReader.java 61.90% <100.00%> (+11.90%) 7.00 <2.00> (-1.00) ⬆️
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 95.00% <100.00%> (+1.66%) 12.00 <0.00> (-1.00) ⬆️
...ogle/cloud/pubsublite/spark/SparkSourceOffset.java 91.48% <100.00%> (+6.38%) 16.00 <1.00> (-1.00) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c2a24...feddaab. Read the comment docs.

@jiangmichaellll jiangmichaellll merged commit f6f1bc4 into master Jan 14, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-spark-fix-assert branch January 14, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants