Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove spark connector as a module #467

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll commented Jan 26, 2021

Since it's moved into java-pubsublite-spark and no longer maintained here.

fixes #450

@jiangmichaellll jiangmichaellll requested review from a team as code owners January 26, 2021 21:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jan 26, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The source code now lives in https://github.com/googleapis/java-pubsublite-spark

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #467 (5e38d80) into master (8b00e43) will increase coverage by 1.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #467      +/-   ##
============================================
+ Coverage     71.55%   73.09%   +1.54%     
+ Complexity      913      835      -78     
============================================
  Files           168      151      -17     
  Lines          4859     4368     -491     
  Branches        209      222      +13     
============================================
- Hits           3477     3193     -284     
+ Misses         1263     1056     -207     
  Partials        119      119              
Impacted Files Coverage Δ Complexity Δ
...oud/pubsublite/internal/wire/SingleConnection.java 74.35% <0.00%> (-7.34%) 16.00% <0.00%> (ø%)
...cloud/pubsublite/internal/wire/SubscriberImpl.java 83.33% <0.00%> (-2.04%) 27.00% <0.00%> (ø%)
...bsublite/internal/wire/RetryingConnectionImpl.java 65.00% <0.00%> (-2.02%) 12.00% <0.00%> (ø%)
...lite/cloudpubsub/internal/AssigningSubscriber.java 86.00% <0.00%> (-1.76%) 11.00% <0.00%> (ø%)
...sublite/internal/wire/ConnectedSubscriberImpl.java 91.93% <0.00%> (-1.51%) 14.00% <0.00%> (ø%)
...internal/wire/PartitionCountWatchingPublisher.java 97.08% <0.00%> (-0.96%) 18.00% <0.00%> (ø%)
...m/google/cloud/pubsublite/beam/PublisherCache.java 45.45% <0.00%> (ø) 3.00% <0.00%> (ø%)
...oud/pubsublite/beam/PubsubLiteUnboundedReader.java 75.42% <0.00%> (ø) 24.00% <0.00%> (ø%)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 89.38% <0.00%> (ø) 24.00% <0.00%> (ø%)
...oogle/cloud/pubsublite/v1/CursorServiceClient.java 82.00% <0.00%> (+2.00%) 14.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b00e43...5e38d80. Read the comment docs.

@anguillanneuf anguillanneuf merged commit ae82cbe into master Jan 26, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-remove-old-module branch January 26, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on jackson
2 participants