Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change message id on PubsubMessages to be an encoded MessageMetadata and rename PublishMetadata to MessageMetadata #482

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

dpcollins-google
Copy link
Collaborator

PublishMetadata is both the partition and offset, and is an ID suitable for deduplication.

Fixes #471

@dpcollins-google dpcollins-google requested a review from a team as a code owner February 2, 2021 18:37
@dpcollins-google dpcollins-google requested a review from a team February 2, 2021 18:37
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #482 (8a6fec5) into master (c709bef) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
+ Coverage     75.31%   75.38%   +0.06%     
- Complexity      758      760       +2     
============================================
  Files           129      129              
  Lines          3865     3875      +10     
  Branches        174      174              
============================================
+ Hits           2911     2921      +10     
  Misses          850      850              
  Partials        104      104              
Impacted Files Coverage Δ Complexity Δ
...ublite/cloudpubsub/internal/WrappingPublisher.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../wire/PartitionCountWatchingPublisherSettings.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...sublite/internal/wire/RoutingPublisherBuilder.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...internal/wire/SinglePartitionPublisherBuilder.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/com/google/cloud/pubsublite/MessageMetadata.java 100.00% <100.00%> (ø) 5.00 <2.00> (?)
...loud/pubsublite/cloudpubsub/MessageTransforms.java 100.00% <100.00%> (ø) 18.00 <2.00> (+2.00)
...oud/pubsublite/cloudpubsub/SubscriberSettings.java 59.42% <100.00%> (+0.59%) 12.00 <0.00> (ø)
...internal/wire/PartitionCountWatchingPublisher.java 97.05% <100.00%> (ø) 18.00 <2.00> (ø)
...oud/pubsublite/internal/wire/RoutingPublisher.java 95.45% <100.00%> (ø) 6.00 <4.00> (ø)
...ublite/internal/wire/SinglePartitionPublisher.java 100.00% <100.00%> (ø) 5.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c709bef...37239cd. Read the comment docs.

@dpcollins-google dpcollins-google requested a review from a team as a code owner February 3, 2021 20:26
…adata

PublishMetadata is both the partition and offset, and is an ID suitable for deduplication.

FIXES: #471
@dpcollins-google dpcollins-google changed the title feat: Change message id on PubsubMessages to be an encoded PublishMetadata feat: Change message id on PubsubMessages to be an encoded MessageMetadata and rename PublishMetadata to MessageMetadata Feb 3, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You don't really need to change README.md as any change in .readme-partials.yaml will trigger an update in README.md.

@dpcollins-google dpcollins-google merged commit a5cedf9 into master Feb 4, 2021
@dpcollins-google dpcollins-google deleted the add-partition branch February 4, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support per partition MessageReceiver
3 participants