Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rebatch messages when restarting a publish stream #496

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

dpcollins-google
Copy link
Collaborator

This prevents publishers which are network isolated for a while from appearing disconnected when the server attempts to acknowledge messages.

This prevents publishers which are network isolated for a while from appearing disconnected when the server attempts to acknowledge messages.
@dpcollins-google dpcollins-google requested a review from a team as a code owner February 5, 2021 14:06
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #496 (592118c) into master (980ce34) will increase coverage by 0.13%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #496      +/-   ##
============================================
+ Coverage     75.38%   75.51%   +0.13%     
- Complexity      760      768       +8     
============================================
  Files           129      129              
  Lines          3875     3896      +21     
  Branches        174      179       +5     
============================================
+ Hits           2921     2942      +21     
+ Misses          850      849       -1     
- Partials        104      105       +1     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/pubsublite/Constants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 91.04% <92.59%> (+1.66%) 31.00 <6.00> (+7.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980ce34...b3893f7. Read the comment docs.

This prevents publishers which are network isolated for a while from appearing disconnected when the server attempts to acknowledge messages.
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2021
@dpcollins-google dpcollins-google merged commit dbf19c9 into master Feb 24, 2021
@dpcollins-google dpcollins-google deleted the rebatch-on-retry branch February 24, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants