feat: Adding ability to create a subscription at HEAD#545
feat: Adding ability to create a subscription at HEAD#545hannahrogers-google merged 26 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
============================================
- Coverage 72.70% 72.66% -0.04%
- Complexity 860 861 +1
============================================
Files 156 156
Lines 4477 4482 +5
Branches 210 211 +1
============================================
+ Hits 3255 3257 +2
- Misses 1102 1104 +2
- Partials 120 121 +1
Continue to review full report at Codecov.
|
dpcollins-google
left a comment
There was a problem hiding this comment.
LGTM after fixes. Ping me once fixed
| @@ -108,6 +119,17 @@ static AdminClient create(AdminClientSettings settings) throws ApiException { | |||
| */ | |||
| ApiFuture<Subscription> createSubscription(Subscription subscription); | |||
There was a problem hiding this comment.
default ApiFuture<Subscription> createSubscription(Subscription subscription) { createSubscription(subscription, OffsetLocation.END); }
There was a problem hiding this comment.
Also modify the comment to make it clear where this creates the subscription
There was a problem hiding this comment.
Done. This is ready for another look. Thanks!
No description provided.