Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding ability to create a subscription at HEAD #545

Merged
merged 26 commits into from
Mar 22, 2021

Conversation

hannahrogers-google
Copy link
Contributor

No description provided.

@hannahrogers-google hannahrogers-google requested review from a team as code owners March 9, 2021 17:46
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Mar 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #545 (02cb149) into master (39e04e4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #545      +/-   ##
============================================
- Coverage     72.70%   72.66%   -0.04%     
- Complexity      860      861       +1     
============================================
  Files           156      156              
  Lines          4477     4482       +5     
  Branches        210      211       +1     
============================================
+ Hits           3255     3257       +2     
- Misses         1102     1104       +2     
- Partials        120      121       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/pubsublite/AdminClient.java 80.00% <100.00%> (+80.00%) 1.00 <1.00> (+1.00)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 100.00% <100.00%> (ø) 19.00 <0.00> (+1.00)
...ubsublite/internal/BlockingPullSubscriberImpl.java 87.93% <0.00%> (-5.18%) 11.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e04e4...02cb149. Read the comment docs.

Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixes. Ping me once fixed

@@ -108,6 +119,17 @@ static AdminClient create(AdminClientSettings settings) throws ApiException {
*/
ApiFuture<Subscription> createSubscription(Subscription subscription);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default ApiFuture<Subscription> createSubscription(Subscription subscription) { createSubscription(subscription, OffsetLocation.END); }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also modify the comment to make it clear where this creates the subscription

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. This is ready for another look. Thanks!

@hannahrogers-google hannahrogers-google added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 16, 2021
@hannahrogers-google hannahrogers-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 22, 2021
@hannahrogers-google hannahrogers-google merged commit c526235 into googleapis:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants