Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Centralize alarm executor creation for Pub/Sub Lite #565

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

dpcollins-google
Copy link
Collaborator

Also prevent creation of per-object thread pools which are largely unused and may prevent shutdown if not using daemon threads.

Also prevent creation of per-object thread pools which are largely unused and may prevent shutdown if not using daemon threads.
@dpcollins-google dpcollins-google requested a review from a team as a code owner March 30, 2021 02:57
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Mar 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #565 (d27b41e) into master (343afbf) will increase coverage by 0.14%.
The diff coverage is 67.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #565      +/-   ##
============================================
+ Coverage     72.63%   72.77%   +0.14%     
- Complexity      861      868       +7     
============================================
  Files           156      157       +1     
  Lines          4488     4493       +5     
  Branches        211      210       -1     
============================================
+ Hits           3260     3270      +10     
+ Misses         1107     1103       -4     
+ Partials        121      120       -1     
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsublite/internal/wire/ServiceClients.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/com/google/cloud/pubsublite/beam/Publishers.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...m/google/cloud/pubsublite/beam/PublisherCache.java 45.45% <36.84%> (-4.55%) 4.00 <3.00> (+1.00) ⬇️
...bsublite/internal/wire/RetryingConnectionImpl.java 64.64% <76.92%> (-0.36%) 12.00 <3.00> (ø)
...blite/internal/wire/PartitionCountWatcherImpl.java 95.34% <100.00%> (ø) 10.00 <0.00> (ø)
.../cloud/pubsublite/internal/wire/PublisherImpl.java 90.97% <100.00%> (-0.07%) 31.00 <0.00> (ø)
...cloud/pubsublite/internal/wire/SubscriberImpl.java 83.20% <100.00%> (-0.14%) 27.00 <0.00> (ø)
...loud/pubsublite/internal/wire/SystemExecutors.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...cloud/pubsublite/beam/PerServerPublisherCache.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...m/google/cloud/pubsublite/beam/PubsubLiteSink.java 85.71% <100.00%> (ø) 10.00 <0.00> (-1.00)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343afbf...d27b41e. Read the comment docs.

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the fix with a simple example to write two messages to a Lite topic. Shutdown worked.

@dpcollins-google dpcollins-google merged commit 5f73967 into master Mar 30, 2021
@dpcollins-google dpcollins-google deleted the fix-publish-beam branch March 30, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants