Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow setting framework tags on cloud pubsub shim. #571

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested a review from a team as a code owner April 1, 2021 13:38
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Apr 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #571 (0fe8598) into master (b1b3cb8) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
- Coverage     72.71%   72.70%   -0.02%     
+ Complexity      867      866       -1     
============================================
  Files           157      157              
  Lines          4493     4495       +2     
  Branches        210      210              
============================================
+ Hits           3267     3268       +1     
- Misses         1106     1107       +1     
  Partials        120      120              
Impacted Files Coverage Δ Complexity Δ
...oud/pubsublite/cloudpubsub/SubscriberSettings.java 58.57% <20.00%> (-0.85%) 11.00 <0.00> (-1.00)
...loud/pubsublite/cloudpubsub/PublisherSettings.java 43.63% <50.00%> (+1.04%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b3cb8...0fe8598. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 2231fbd into master Apr 1, 2021
@dpcollins-google dpcollins-google deleted the framework_on_cps_shim branch April 1, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants