Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set initial location when connecting subscribe streams #664

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

tmdiep
Copy link
Collaborator

@tmdiep tmdiep commented Jun 4, 2021

  • Sets the InitialSubscribeRequest.initial_location field when reconnecting subscribe streams.
    • This speeds up reconnects by seeking to the next offset in the initial subscribe, rather than as a subsequent seek request.
    • Setting the initial location to COMMITTED_CURSOR also acknowledges the client's receipt of the RESET signal.
  • Completes the handling of admin/out of band seeks.
  • Removes the initial seek from all subscriber wrapper implementations. When dependent libraries (e.g. Spark, Kafka) are updated to a new release of this library, they will be updated to set the initial location for SubscriberBuilder.

@tmdiep tmdiep requested a review from a team as a code owner June 4, 2021 08:36
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@tmdiep tmdiep requested a review from a team as a code owner June 8, 2021 05:06
@tmdiep tmdiep merged commit 65ced46 into googleapis:master Jun 8, 2021
@tmdiep tmdiep deleted the use_init_location branch June 8, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants