Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use right x-version-update in POM files #68

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented May 20, 2020

Use <!-- {x-version-update:google-cloud-pubsublite:released} --> in samples/install-without-bom, and samples/snippets (for now, to be removed later).

Use <!-- {x-version-update:google-cloud-pubsublite:current} --> in samples/snapshot.


Kokoro - Test: Java 11 and Kokoro - Test: Java 8 are flaky. Kokoro - CI seems stuck Other libraries have migrated to using GitHub actions for these.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
@anguillanneuf anguillanneuf changed the title use right x-version-update in POM files chore: use right x-version-update in POM files May 20, 2020
@anguillanneuf anguillanneuf changed the title chore: use right x-version-update in POM files fix: use right x-version-update in POM files May 20, 2020
@@ -64,7 +64,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsublite</artifactId>
<version>0.1.4</version><!-- {x-version-update:google-cloud-pubsublite:current} -->
<version>0.1.4</version><!-- {x-version-update:google-cloud-pubsublite:released} -->
Copy link
Contributor Author

@anguillanneuf anguillanneuf May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove the tag after Pub/Sub Lite works with libraries-bom.

@anguillanneuf anguillanneuf merged commit 12edb04 into master May 20, 2020
@anguillanneuf anguillanneuf deleted the samples-pom branch May 20, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants