Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make PubsubLiteIO not final and have protected constructor #715

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

dpcollins-google
Copy link
Collaborator

This will enable creating a POC for aliasing it in the beam repo.

This class has no instance methods, just static ones.

This will enable creating a POC for aliasing it in the beam repo.
@dpcollins-google dpcollins-google requested a review from a team as a code owner June 17, 2021 14:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jun 17, 2021
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2021
@dpcollins-google dpcollins-google merged commit a6a7fc2 into master Jun 17, 2021
@dpcollins-google dpcollins-google deleted the PubsubLiteIO-not-final branch June 17, 2021 17:12
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants