Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): deflake SubscriptionPartitionProcessorImplTest #768

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

manuelmenzella-google
Copy link
Contributor

Wait for 10ms for the PartitionProcessor to fail after failing the underlying subscriber.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #767 ☕️

@manuelmenzella-google manuelmenzella-google requested a review from a team as a code owner July 27, 2021 21:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jul 27, 2021
@manuelmenzella-google manuelmenzella-google changed the title Fix flakiness in SubscriptionPartitionProcessorImplTest fix: deflake SubscriptionPartitionProcessorImplTest Jul 27, 2021
The test case expects the processor to fail immediately (with deadline of zero) after failing the underlying subscriber. However, the actual failing is done asynchronously. Waiting for a little bit removes the flakiness.
@anguillanneuf anguillanneuf changed the title fix: deflake SubscriptionPartitionProcessorImplTest fix(test): deflake SubscriptionPartitionProcessorImplTest Jul 28, 2021
@anguillanneuf anguillanneuf merged commit c34e430 into master Jul 28, 2021
@anguillanneuf anguillanneuf deleted the fix-flakiness branch July 28, 2021 13:50
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 29, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [0.18.0](https://www.github.com/googleapis/java-pubsublite/compare/v0.17.0...v0.18.0) (2021-07-29)


### Features

* split versions.txt to independently release the Beam IO ([#766](https://www.github.com/googleapis/java-pubsublite/issues/766)) ([b6e48dc](https://www.github.com/googleapis/java-pubsublite/commit/b6e48dc7f21ad3f8857d42ca2e3ebc549eea35f6))
* Update CloudPubsubChecks to CloudPubsubTransforms ([#730](https://www.github.com/googleapis/java-pubsublite/issues/730)) ([2e10924](https://www.github.com/googleapis/java-pubsublite/commit/2e109244e43ed4beec50ba9cbc5efadddfb53b5c))


### Bug Fixes

* deflake SubscriptionPartitionProcessorImplTest ([#768](https://www.github.com/googleapis/java-pubsublite/issues/768)) ([c34e430](https://www.github.com/googleapis/java-pubsublite/commit/c34e4303cfb8ce9d0b812ad5c1dd306af32a544e))
* remove DlqProvider which should remain in the beam repo and bump beam version ([#772](https://www.github.com/googleapis/java-pubsublite/issues/772)) ([a540c1d](https://www.github.com/googleapis/java-pubsublite/commit/a540c1dd8eb7e7b2e6afd03550433060635a62fc))


### Dependencies

* define Beam version as a Maven property in pom ([#714](https://www.github.com/googleapis/java-pubsublite/issues/714)) ([69106fe](https://www.github.com/googleapis/java-pubsublite/commit/69106fe309040bc24f2af4c70dfddb602963f365))
* update dependency com.google.apis:google-api-services-bigquery to v2-rev20210617-1.32.1 ([#773](https://www.github.com/googleapis/java-pubsublite/issues/773)) ([e904392](https://www.github.com/googleapis/java-pubsublite/commit/e9043922fbf83220aeff301890fc58b33ae925b4))
* Version bump cloud BOM and remove no longer needed dependency management settings ([#777](https://www.github.com/googleapis/java-pubsublite/issues/777)) ([1cd23cb](https://www.github.com/googleapis/java-pubsublite/commit/1cd23cb3295d521453c1658c25468f4bd82962e2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target SubscriptionPartitionProcessorImplTest is flaky
2 participants