Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep track of internal seek #87

Merged
merged 3 commits into from
May 27, 2020

Conversation

hannahrogers-google
Copy link
Contributor

If a seek is inFlight and a stream is retried, retrying the inFlight seek.

If an internal seek is in flight, and a client initiates a seek, block until the internal seek completes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2020
new Monitor.Guard(monitor.monitor) {
@Override
public boolean isSatisfied() {
return !internalSeekInFlight || shutdown;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If shutdown == true, we'll checkState-fail right below this. I think we should return an immediately-failed Future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should already happen. The catch block will catch the checkState failure and will return an immediateFailedFuture.

@dpcollins-google dpcollins-google merged commit a7e09ff into googleapis:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants